Add capture_(request|response)_headers to instrument_httpx
#671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #671 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 137 137
Lines 10721 10835 +114
Branches 1470 1488 +18
==========================================
+ Hits 10721 10835 +114 ☔ View full report in Codecov by Sentry. |
Deploying logfire-docs with
|
| Latest commit: |
810ddd9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b49d923f.logfire-docs.pages.dev |
| Branch Preview URL: | https://alex-httpx-headers.logfire-docs.pages.dev |
Kludex
commented
Dec 16, 2024
alexmojaki
reviewed
Dec 16, 2024
| async_request_hook = cast('AsyncRequestHook | None', final_kwargs.get('async_request_hook')) | ||
| async_response_hook = cast('AsyncResponseHook | None', final_kwargs.get('async_response_hook')) | ||
|
|
||
| if capture_request_headers: # pragma: no cover |
There was a problem hiding this comment.
non-blocking, but things here are getting complicated enough that this is worth testing. it could either make a real request or a mini local server could be set up in another thread.
alexmojaki
approved these changes
Dec 17, 2024
| client: None, | ||
| capture_request_headers: bool = False, | ||
| capture_response_headers: bool = False, | ||
| **kwargs: Unpack[HTTPXInstrumentKwargs], |
There was a problem hiding this comment.
Still want to get rid of these Unpacks and kwargs eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.